This repository was archived by the owner on Jul 15, 2022. It is now read-only.
Pipelining for php.stdin and non-blocking filesystem calls#11
Merged
mkschreder merged 2 commits intomkschreder:masterfrom Dec 31, 2015
Merged
Pipelining for php.stdin and non-blocking filesystem calls#11mkschreder merged 2 commits intomkschreder:masterfrom
mkschreder merged 2 commits intomkschreder:masterfrom
Conversation
Owner
|
Let's hope it works then. Merging it without testing. |
mkschreder
added a commit
that referenced
this pull request
Dec 31, 2015
Pipelining for php.stdin and non-blocking filesystem calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipelining the request directly into stdin solves for me following problem with uploading larger files:
https://stackoverflow.com/questions/21388363/getting-econnreset-on-child-stdin-write
synchronous calls block the entire node process until the response is there, meaning that no other http request can be handled until it got the results for fs.existsSync() & fs.statSync()
now async & removed the unnecessary fs.exists()-check ( fs.stat() does both)